more stable code with better error handling

app/functions.py

@@ -165,8 +165,11 @@ def make_post(args):
 		# user has revoked the token given to the bot
 		# this needs to be dealt with properly later on, but for now, we'll just disable the bot
 		c.execute("UPDATE bots SET enabled = FALSE WHERE handle = %s", (handle,))
+	except:
+		print("Failed to create post for {}".format(handle))
 
 	if id == None:
 		# this wasn't a reply, it was a regular post, so update the last post date
 		c.execute("UPDATE bots SET last_post = CURRENT_TIMESTAMP() WHERE handle = %s", (handle,))
 		db.commit()
+	c.close()

app/service.py

@@ -2,33 +2,55 @@
 import MySQLdb
 from mastodon import Mastodon
 from multiprocessing import Pool
+import requests
 import json
 import functions
 
 cfg = json.load(open('config.json'))
 
 def update_icon(bot):
-	db = MySQLdb.connect(
+	try:
-		host = cfg['db_host'],
+		db = MySQLdb.connect(
-		user=cfg['db_user'],
+			host = cfg['db_host'],
-		passwd=cfg['db_pass'],
+			user=cfg['db_user'],
-		db=cfg['db_name'],
+			passwd=cfg['db_pass'],
-		use_unicode=True,
+			db=cfg['db_name'],
-		charset="utf8mb4"
+			use_unicode=True,
-	)
+			charset="utf8mb4"
+		)
+	except:
+		print("Failed to connect to database.")
+		return
+
+
+	url = "https://{}".format(bot['handle'].split("@")[2])
+	try:
+		r = requests.head(url, timeout=10, allow_redirects = True)
+		if r.status_code != 200:
+			raise
+	except:
+		print("{} is down.".format(url))
+		return
 
-	print("Updating cached icon for {}".format(bot['handle']))
 	client = Mastodon(
 		client_id = bot['client_id'],
 		client_secret = bot['client_secret'],
 		access_token = bot['secret'],
-		api_base_url = "https://{}".format(bot['handle'].split("@")[2])
+		api_base_url = url
 	)
 
-	avatar = client.account_verify_credentials()['avatar']
+
 	c = db.cursor()
+	try:
+		avatar = client.account_verify_credentials()['avatar']
+	except:
+		c.execute("UPDATE bots SET icon_update_time = CURRENT_TIMESTAMP() WHERE handle = %s", (bot['handle'],))
+		db.commit()
+		c.close()
+		return
 	c.execute("UPDATE bots SET icon = %s, icon_update_time = CURRENT_TIMESTAMP() WHERE handle = %s", (avatar, bot['handle']))
 	db.commit()
+	c.close()
 
 print("Establishing DB connection")
 db = MySQLdb.connect(